Remove Advertisements

ThatJustHappened: Combat Event Announcement Mod

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Wed Jun 29, 2011 2:40 am

TJH is broken again with 4.2. I'd love to try and fix it myself but I have no programming experience and would probably break more things than I fix. However because TJH works with the combat log I'd assume this has something to do with it:

http://us.battle.net/wow/en/forum/topic/2483689044
Code: Select all
4.1: timestamp, event, hideCaster, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags
4.2: timestamp, event, hideCaster, srcGUID, srcName, srcFlags, srcFlags2, dstGUID, dstName, dstFlags, dstFlags2

It is somewhat speculation at this point that the two new arguments are for flags, from what I've been able to fool around with, they're 0 for most things, except empty destinations so far (where it does look like flags).

4.1:
SPELL_AURA_APPLIED,0x04000000003FAF22,"Zonker",0x511,0x04000000003FAF22,"Zonker",0x511,6117,"Mage Armor",0x40,BUFF
SPELL_CAST_START,0x04000000003FAF22,"Zonker",0x511,0x0000000000000000,nil,0x80000000,30451,"Arcane Blast",0x40

4.2:
SPELL_AURA_APPLIED,0x020000000019C513,"Zonker",0x511,0x0,0x020000000019C513,"Zonker",0x511,0x0,6117,"Mage Armor",0x40,BUFF
SPELL_CAST_START,0x020000000019C513,"Zonker",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,30451,"Arcane Blast",0x40
Echaa
 
Posts: 61
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Wed Jun 29, 2011 10:20 am

I posted an updated version on wowinterface yesterday afternoon. Did you download it?
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Wed Jun 29, 2011 1:08 pm

fuzzygeek wrote:I posted an updated version on wowinterface yesterday afternoon. Did you download it?


I did! Thanks for keeping this awesome addon updated.

My guildmates are always asking me to make a rule for this or a rule for that.... and I have a funny story. I wanted to make a rule so that when our holy pally put Beacon of Light on me, it'd whisper him back and say "Thanks for the bacon! mmmmm". So I made a rule for it. What was really funny though is that apparently, when a pally heals someone else, the heal that lands on me is also called "Beacon of Light". I made the rule right before a boss fight, and I was tanking. I think it was Chimereon. So the fight starts and all of a sudden I see that I am whispering our holy pally like crazy, just repeating Thanks for the bacon! mmmmm over and over and over. I nearly fell out of my chair laughing, and in vent the guy is like "OMG arees stop it, I cant see any of my chat warnings". I was to busy tanking though to try and disable it, so I just waited until the fight was over.

BTW, if anyone is interested, this is the correct rule to use
Code: Select all
/tjh rule SPELL_CAST_SUCCESS;;Arees;Beacon of Light;;*SOURCE;Thanks for the bacon! mmmmm;
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Wed Jun 29, 2011 2:54 pm

Last night I put a keyword "trap" to try to get a handle on the timing of Shannox traps.

The spam from explosive trap ticks was amazing.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby inthedrops » Thu Jun 30, 2011 12:31 am

fuzzygeek wrote:Last night I put a keyword "trap" to try to get a handle on the timing of Shannox traps.

The spam from explosive trap ticks was amazing.


haha! Had a few people in may raid stealing my darn traps too. I caught myself almost saying something foul in vent....I mean come on, someone walked from 20 yards away, towards me, and RIGHT into the trap I was saving for the dog.....grrr

But yeah, this is a great addon thanks for keeping it alive.
inthedrops
Maintankadonor
 
Posts: 1281
Joined: Mon Oct 29, 2007 9:19 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Fetzie » Thu Jun 30, 2011 3:18 am

Code: Select all
Expression Editor code for trap summons:

sourceName = 'Shannox' and targetName = 'Crystal Prison Trap' or targetName = 'Immolation Trap'


He always summons a crystal trap first. Then he summons two Immolation traps. The timing is approximately 25 seconds between crystal traps and 8 seconds between immolation traps
Fetzie | Protection Paladin | EU-Kazzak
Author of the TankSpot Protection Paladin Guide
Image
Sagara wrote:You see, you need to *spread* the bun before you insert the hot dog.

bldavis wrote:we are trying to extend it as long as we can...it just never seems to last very long
User avatar
Fetzie
 
Posts: 2183
Joined: Sat Feb 07, 2009 9:43 am
Location: Karlsruhe, Germany

Re: ThatJustHappened: Combat Event Announcement Mod

Postby munificent » Sun Jul 17, 2011 10:07 am

Long-time lurker but big fan of what this addon can do. Only just discovered it. I'm looking for a resource of written rules for the Firelands bosses, if such a list exists. Specifically I want to track when one of our raid takes more than eight stacks from Baleroc's crystal and auto-yell it to shame him immortally. Perhaps some more seasoned heads might help get me started?
munificent
 
Posts: 5
Joined: Sun Jul 17, 2011 10:04 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Sun Jul 17, 2011 1:28 pm

There is no internal mechanic for tracking how many stacks, although now that I think about it you could do a check for Torment (8), since TJH just does string checks, and it apparently shows up a Torment (8) in the logs. At least in WoL; I'll check actual logs when I get back to my computer.

Edit: Logs are different:

7/14 18:02:11.359 SPELL_AURA_APPLIED_DOSE,0xF130D0F7000039A3,"Shard of Torment",0xa48,0x0,0x05000000045F3998,"Katokal",0x514,0x0,100230,"Torment",0x20,DEBUFF,3


I've kind of been wanting something like this as well, so I'll see if I can't add that functionality.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Sun Jul 17, 2011 4:00 pm

I've uploaded a new version 4.2.1 that allows you to trigger off stacks -- there is a field for #stacks on the "spell/stack" line. Right now I have it defaulting to stacks >= your entered value, but can make it more flexible in the future.

http://www.wowinterface.com/downloads/i ... clysm.html

Also it looks like they changed some functionality around UIDropDownMenu_SetSelectedID that throws a Lua error, but it doesn't affect functionality. Haven't had a chance to hunt that down yet. Drops are you familiar with this func off the top of your head -- do you know why it's throwing an error trying to index local 'icon'?

I did some very perfunctory checking with this; going to go run something and see if it blows up. If you use this let me know if you run into any problems.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby munificent » Mon Jul 18, 2011 8:43 am

Fuzzy, thank you for looking into this and I'm glad I was able to highlight something useful to ad to the mod (even if was through sheer ignorance). I'm going to push my luck and ask how I might implement this new feature for the torment stacks, as i still don't have much of a clue.

Much obliged for the help!
munificent
 
Posts: 5
Joined: Sun Jul 17, 2011 10:04 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Jul 18, 2011 10:17 am

I found a logic error last night and fixed it, I think, so you might want to grab 4.2.1.1.

Image

If you check out the "Spell/Stacks:" line, that should be what you're looking for.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Jul 18, 2011 8:15 pm

I've got a quick question. Can you add (or remove) anything from the code so that the curse updater client doesn't see TJH? It tells me all the time I need to update TJH to version 3.0.5.2 even though I tell the client to ignore this addon. It will ignore it for about a week and then decide to tell me it needs updating again.

I'm guessing there is a file that has some metadata in it that the curse client looks for. Because it wont list addons that aren't available on Curse. It's possible though that it just does string matching on the addon names, but that would be a dumb way to do it. I'm pretty sure that you can assign your addon a GUID to prevent naming conflicts, so maybe you could change the GUID for TJH? That's just speculation on my part though...
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby munificent » Tue Jul 19, 2011 8:24 am

Fuzzy, thanks very much indeed!
munificent
 
Posts: 5
Joined: Sun Jul 17, 2011 10:04 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Jul 19, 2011 10:04 am

@arees: I'm not certain how the Curse client tags mods in its database, or how it identifies them. Looking through the TJH codebase I'm not seeing any kind of GUID. Some shallow googling around doesn't offer any insight either. :[

I should probably start the process to take over the project on Curse again, but they were unresponsive last time.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Wed Jul 20, 2011 10:30 am

After doing Baleroc last night, I decided hard limiting to >= was stupid. So:

4.2.1.2: Added comparison operator support to stacks. You can now enter, for example, ">=7" in the "Stacks" field to trigger off 7 or more Stacks.
- Valid operators are: >=, <=, <>, >, <, =.
- Entering a number but no operator will default to "=".
- Entering an operator but no number is nonsensical, but will default to 0 stacks.

Image
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: Bing [Bot], Yahoo [Bot] and 1 guest


Remove Advertisements

Who is online

In total there are 3 users online :: 2 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: Bing [Bot], Yahoo [Bot] and 1 guest