4.1 combat log breakage.

[Dianora]

It's breaking so many thing it's not even funny. Thus far, I've disabled Skada, DBM, and it's still lagging like hell. I might have to go commando style just to see what else is broken and enable one thing at a time.

[fuzzygeek]

Adding an argument to the beginning of the arg list is a bit of a headscratcher.

[Dianora]

MBST was the culprit. Unfortunately, the guy Miks have stopped playing and I have to use some directed hack to get it working.

[fuzzygeek]

Yeah, the old COMBAT_LOG_EVENT_UNFILTERED used to return:

EventType, Timestamp, Event, sourceGUID, sourceName, ...

It now returns:

EventType, Timestamp, hideCaster, Event, sourceGUID, sourceName, ...

So things parsing the combat log event are going haywire.

I'm sure that's not the only change, but it's what broke MSBT and TJH.

[_Chloe]

It's the culprit for pretty much every lua error going so far.

[Dianora]

Yeah, the old COMBAT_LOG_EVENT_UNFILTERED used to return:

EventType, Timestamp, Event, sourceGUID, sourceName, ...

It now returns:

EventType, Timestamp, hideCaster, Event, sourceGUID, sourceName, ...

So things parsing the combat log event are going haywire.

I'm sure that's not the only change, but it's what broke MSBT and TJH.

I think it's high time for me to install WinGrep and do a global search and replace on ALL LUA files for this parser.

[RedAces]

Yeah, the old COMBAT_LOG_EVENT_UNFILTERED used to return:

EventType, Timestamp, Event, sourceGUID, sourceName, ...

It now returns:

EventType, Timestamp, hideCaster, Event, sourceGUID, sourceName, ...

So things parsing the combat log event are going haywire.

I'm sure that's not the only change, but it's what broke MSBT and TJH.

I think it's high time for me to install WinGrep and do a global search and replace on ALL LUA files for this parser.

And, if you want it to work after the changes to the combat log in 4.1, do this.

Edit line 344 of MSBTParser.lua to:

local function ParseLogMessage(timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, recipientGUID, recipientName, recipientFlags, ...)

and edit line 698 of MSBTTriggers.lua to

local function HandleCombatLogTriggers(timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, recipientGUID, recipientName, recipientFlags, ...)

Source: http://wow.curseforge.com/addons/mik-sc ... ttle-text/

Bye, RedAces.

[fuzzygeek]

I think it's high time for me to install WinGrep and do a global search and replace on ALL LUA files for this parser.

I love me some wingrep, but this actually won't fix it since addon authors tend to write their own parsers.

Like, MSBT had a function, but the original TJH author just extracted the results into the cleverly named variables "arg2", "arg4", "arg5" etc.

When I went and fixed THJ I changed the variable names to "argEvent", "argSourceGUID", "argSourceName" and so on and so forth, so it'll be a bit more maintainable in the future.