ThatJustHappened: Combat Event Announcement Mod

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Tue Dec 28, 2010 6:48 am

fuzzygeek wrote:The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.


Can that stack thing be also included in the 4.0.x version? Pretty please?
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Vladogor » Thu Dec 30, 2010 1:39 pm

The updated version does not seem to work for me. Does it matter if the source and spell names are in Russian? Thnx
Vladogor
 
Posts: 14
Joined: Wed Feb 04, 2009 11:06 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby MopA » Mon Jan 03, 2011 10:50 am

You should also add
Code: Select all
...
   if (select(13, ...) ~= nil) then arg13 = select(13, ...); end
...

Since interrupted spell name doesn't work.

also
Code: Select all
   if (select(14, ...) ~= nil) then arg14 = select(14, ...); end
   if (select(15, ...) ~= nil) then arg15 = select(15, ...); end

For dispell aura type or whatever =P
MopA
 
Posts: 6
Joined: Tue May 19, 2009 10:30 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Wed Jan 05, 2011 1:40 pm

Is this mod working? I would LOVE to have it.
Xkonvikt
 
Posts: 38
Joined: Mon Dec 20, 2010 2:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Thu Jan 06, 2011 8:38 am

Xkonvikt wrote:Is this mod working? I would LOVE to have it.


Link page 26 is a working 4.0.x version
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Myrmidon » Thu Jan 06, 2011 12:25 pm

Thank you so much for updating TJH Arees! Works great :)

People looking for an update of this addon, again, go to page 26!
Image
Myrmidon
 
Posts: 4
Joined: Thu Jan 06, 2011 12:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sat Jan 08, 2011 12:25 pm

Myrmidon wrote:Thank you so much for updating TJH Arees! Works great :)

People looking for an update of this addon, again, go to page 26!


I cant take the credit for that.... Fuzzy posted the changes he made to the code, so I made them and uploaded it since so many people were requesting it.

I was wondering though if anyone has any useful rules for the new raids.

If anyone ever picked up this addon to update in the future there is one major thing I would love to have added. It needs to be modular. This way I can have rules for ICC that load only when im in ICC, rules for just BOT, BWD, and so on and so forth that only load when im in that instance. This would reduce the cpu power needed by the addon because it would have less rules to check every single combat log entry against.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Sat Jan 08, 2011 8:47 pm

From what I can see this mod is not working or I don't have a working set of codes. Can someone rewrite the codes oin the 1st page of this post?
Xkonvikt
 
Posts: 38
Joined: Mon Dec 20, 2010 2:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sat Jan 08, 2011 8:53 pm

Xkonvikt wrote:From what I can see this mod is not working or I don't have a working set of codes. Can someone rewrite the codes oin the 1st page of this post?


Did you download the updated version I linked to on the previous page?
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Jan 10, 2011 10:57 am

I can't take credit either; Dukka posted an outline of how he got it to work and I just posted specifics.

Also, the mod appears to be reporting stacks (this morning it reported stacks of Mortal Strike in SFK, which it hasn't been doing). I suspect something changed client-side, but have no way of checking now.

I did add the lines MopA posted above several days ago, but I think the stack reporting just started this morning.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Jan 10, 2011 4:22 pm

fuzzygeek wrote:Also, the mod appears to be reporting stacks (this morning it reported stacks of Mortal Strike in SFK, which it hasn't been doing). I suspect something changed client-side, but have no way of checking now.


Can you post an example rule you use that reports stacks? There are several things I'd like to have this for, and im wondering if you're rules are just formatted a little differently.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Jan 10, 2011 4:37 pm

The triggered lines were:

"SPELL_AURA_APPLIED;;;Mortal Wound;raid;SAY;", -- [18]
"SPELL_AURA_REMOVED;;;Mortal Wound;raid;SAY;", -- [19]

Very simple. Think they were originally used for Precious and Stinky, but they triggered off Lord Godfrey this morning. I am certain they did not the last time I was in SFK.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5130
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Thu Jan 13, 2011 10:59 am

Arees wrote:
Xkonvikt wrote:From what I can see this mod is not working or I don't have a working set of codes. Can someone rewrite the codes oin the 1st page of this post?


Did you download the updated version I linked to on the previous page?



I did. When I open the addon and click the code list nothing comes up. Then I tried to copy paste codes from page one into he list and they didn't work. What am I doing wrong here?
Xkonvikt
 
Posts: 38
Joined: Mon Dec 20, 2010 2:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Thu Jan 13, 2011 3:36 pm

Xkonvikt wrote:I did. When I open the addon and click the code list nothing comes up.


That's because there are no rules by default. You have to add rules for what you want.

Xkonvikt wrote:Then I tried to copy paste codes from page one into he list and they didn't work. What am I doing wrong here?


When you type in /tjh a window will appear. There is a button that says enable or disable. Whatever it says is the state it is in. It's not clear I know, when I see a button that says enable, I think I should need to click it to enable it, but for this addon its backwards. If it says disable, click it to change it back to enable. I think it may even be disabled by default too, though im not sure on that one.

try this rule. It will whisper anyone in your raid who has hand of salvation cast on them. Cast it on yourself and it will send you a whisper.

/tjh rule SPELL_AURA_APPLIED;;;Hand of Salvation;raid;*TARGET;Watch your threat... you have been salved by *source!
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Thu Jan 13, 2011 3:43 pm

Thank you I will try that and see what happens.
Xkonvikt
 
Posts: 38
Joined: Mon Dec 20, 2010 2:22 pm

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: Google [Bot] and 1 guest

Who is online

In total there are 2 users online :: 1 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: Google [Bot] and 1 guest