ThatJustHappened: Combat Event Announcement Mod

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Sun Nov 07, 2010 6:03 pm

Pyched wrote:
fuzzygeek wrote:Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.


I had to change this:GetID() to self:GetID() instead in order to get the addon to work.


Instead? Isn't that what I have written?
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sun Nov 07, 2010 6:36 pm

fuzzygeek wrote:
Pyched wrote:
fuzzygeek wrote:Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.


I had to change this:GetID() to self:GetID() instead in order to get the addon to work.


Instead? Isn't that what I have written?


No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Nov 08, 2010 10:01 am

WATERBOYsh wrote:No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()


Oh wow. Fixed.

You'd think I'd have a better eye for code punctuation after all these years.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Nov 08, 2010 5:54 pm

fuzzygeek wrote:You'd think I'd have a better eye for code punctuation after all these years.


I've only just started getting into the LUA addon thing, and I find myself putting dots instead of colons and ending lines with a semi-colon... so it's understandable.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby majorwoo » Tue Nov 09, 2010 8:28 am

If someone wants to pm/email me the file I will be glad to host them for us until curse is (if) updated.
Image
Despite all my rage, I am still just a Paladin Tank.
User avatar
majorwoo
 
Posts: 348
Joined: Tue May 20, 2008 7:24 am
Location: Atlanta, GA, USA

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Nov 09, 2010 9:46 am

The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Tue Nov 09, 2010 1:25 pm

fuzzygeek wrote:The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.


Pretty sure the mod never announced stacks. A while back Modus updated to code to do stack counting and posted it here.

I haven't had any issues with TJH after editing the source code.

**edit**
I guess I should say the official addon never announced stacks.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Nov 09, 2010 2:34 pm

Hmm, I've never used Modus' fork, and I used to announce phase punch, puppy bites, fester stacks and the like.

Also, I reverted to the version I was using in 3.x that did stack announcements and applied the 4.x code fixes, and the announces (other than the initial effect) stopped.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Mon Dec 13, 2010 10:08 am

Anybody got it to working for 4.0+ and can upload it somewhere?
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Dec 13, 2010 4:11 pm

Sarkan-ZdC wrote:Anybody got it to working for 4.0+ and can upload it somewhere?


If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Tue Dec 21, 2010 5:50 pm

Arees wrote:
Sarkan-ZdC wrote:Anybody got it to working for 4.0+ and can upload it somewhere?


If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.


I got you a PM but if somebody else can upload it somewhere (rapidshare.com) I would be very grateful
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby theothersteve7 » Wed Dec 22, 2010 1:41 pm

I intend to crack this open sometime tomorrow. Given Blizzard's rules about what rights you have when you author an addon, I can probably just throw the branch up on Curse, right? I've never done anything like that before, just asking.

Oh. Unless, is Modus the author? I should check who the author is.

I was kind of famous for using this mod in Wrath, and I really miss it. You can do some very clever things with it. Also, I learned that using it directly for Divine Guardian is a bad idea - it announces it once for each member of your raid >_<
Moo.
theothersteve7
 
Posts: 385
Joined: Tue Nov 25, 2008 11:45 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Thu Dec 23, 2010 6:39 am

Original Author: http://www.curseforge.com/profiles/belleboom/

Did not update any of his mods for more then a year.

Usually it is done that you call the new mod something like "TJH reloaded" and say in the description that you only fixed the original mod found here.
Happens a los with mods.

And I still would be eternaly grateful :)
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sun Dec 26, 2010 6:55 pm

I had more people PM me for my modified version of TJH that I thought I would have. I haven't answered because I was away for Christmas and didn't have access to my PC. Now that I'm home I have uploaded the modified version of it here.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Mon Dec 27, 2010 3:31 pm

Thank you very much!
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Tue Dec 28, 2010 6:48 am

fuzzygeek wrote:The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.


Can that stack thing be also included in the 4.0.x version? Pretty please?
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Vladogor » Thu Dec 30, 2010 1:39 pm

The updated version does not seem to work for me. Does it matter if the source and spell names are in Russian? Thnx
Vladogor
 
Posts: 5
Joined: Wed Feb 04, 2009 11:06 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby MopA » Mon Jan 03, 2011 10:50 am

You should also add
Code: Select all
...
   if (select(13, ...) ~= nil) then arg13 = select(13, ...); end
...

Since interrupted spell name doesn't work.

also
Code: Select all
   if (select(14, ...) ~= nil) then arg14 = select(14, ...); end
   if (select(15, ...) ~= nil) then arg15 = select(15, ...); end

For dispell aura type or whatever =P
MopA
 
Posts: 6
Joined: Tue May 19, 2009 10:30 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Wed Jan 05, 2011 1:40 pm

Is this mod working? I would LOVE to have it.
Xkonvikt
 
Posts: 32
Joined: Mon Dec 20, 2010 2:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Thu Jan 06, 2011 8:38 am

Xkonvikt wrote:Is this mod working? I would LOVE to have it.


Link page 26 is a working 4.0.x version
Sarkan-ZdC
 
Posts: 297
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Myrmidon » Thu Jan 06, 2011 12:25 pm

Thank you so much for updating TJH Arees! Works great :)

People looking for an update of this addon, again, go to page 26!
Image
Myrmidon
 
Posts: 4
Joined: Thu Jan 06, 2011 12:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sat Jan 08, 2011 12:25 pm

Myrmidon wrote:Thank you so much for updating TJH Arees! Works great :)

People looking for an update of this addon, again, go to page 26!


I cant take the credit for that.... Fuzzy posted the changes he made to the code, so I made them and uploaded it since so many people were requesting it.

I was wondering though if anyone has any useful rules for the new raids.

If anyone ever picked up this addon to update in the future there is one major thing I would love to have added. It needs to be modular. This way I can have rules for ICC that load only when im in ICC, rules for just BOT, BWD, and so on and so forth that only load when im in that instance. This would reduce the cpu power needed by the addon because it would have less rules to check every single combat log entry against.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Xkonvikt » Sat Jan 08, 2011 8:47 pm

From what I can see this mod is not working or I don't have a working set of codes. Can someone rewrite the codes oin the 1st page of this post?
Xkonvikt
 
Posts: 32
Joined: Mon Dec 20, 2010 2:22 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sat Jan 08, 2011 8:53 pm

Xkonvikt wrote:From what I can see this mod is not working or I don't have a working set of codes. Can someone rewrite the codes oin the 1st page of this post?


Did you download the updated version I linked to on the previous page?
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Jan 10, 2011 10:57 am

I can't take credit either; Dukka posted an outline of how he got it to work and I just posted specifics.

Also, the mod appears to be reporting stacks (this morning it reported stacks of Mortal Strike in SFK, which it hasn't been doing). I suspect something changed client-side, but have no way of checking now.

I did add the lines MopA posted above several days ago, but I think the stack reporting just started this morning.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: Bing [Bot] and 1 guest

Who is online

In total there are 2 users online :: 1 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: Bing [Bot] and 1 guest