HolyTrinity - Holy Power addon (Updated for MoP)

[PsiVen]

I will throw in Holy Shock with the next build, though it will probably default to disabled... Not sure why you want to track a 6sec cooldown

Updates:

-- v1.04 --
Corrected the default Holy Power spacing to be left-to-right (negative values flip the spacing direction).
Fixed a bug where timers would expire with nil durations and produce LUA errors.

-- v1.03 --
Added configuration options for spacing the Holy Power bars. They can now be stacked vertically and reversed.
Added configuration options for resizing the Holy Power bars. This stretches the texture and may not look ideal in all shapes and sizes.

[Barboza]

Edit: Hey there, I'd like to thank you for considering Holy Shock as CD for HolyTrinity but after thinking abit more about it there is better ways for tracking such small CD and it would be just a loss of time. Honestly I dont wanna make it any "heavier" specially because its a really well designed addon that many pallys can use regardless of the spec.
Tbh yesterday was the first day I've came to this website and what I can say is that I really enjoined what I saw^^. I am considering playing prot as OS on Cataclysm so I will definatly come here to read the forums and check on new updates.
Thanks for everything

Best Regards, Barboza

[Raeli]

Is it possible to remove LibBetterBlizzOptions from the addon please?

I like this a lot, but I don't really like the idea of having to delete this from the addon each time I update it.

[Necrolite]

Holy cow ... (no pun intended)

This is exactly what I need. stylish, functional, suits the type of ui as a whole that i want to put together. thank you for sharing this

[PsiVen]

Cheers Another update today:

-- v1.05 --
Added optional sound effects for when you hit 3 Holy Power.
Fixed a bug where others paladins' abilities could trigger errors.
Added Holy Shock support by request (disabled by default).

Is it possible to remove LibBetterBlizzOptions from the addon please?

I like this a lot, but I don't really like the idea of having to delete this from the addon each time I update it.

Gone in the next release. Sorry, didn't notice this one was outdated anyway. I don't think it actually does anything in 4.0.1.

[mclem]

Just to add to the litany of requests: Would it be possible to have some sort of convenient (and optional) indicator that Holy Shield is up? If something happens to break my rotation I do tend to lose track of when it expires while trying to get back on-track.

[Necrolite]

Just noticed the update you posted after my initial post, problem i was having was other paladins stuff was causing a massive fps drop until i reloaded my ui - just put the 1.05 in and so far, so good. no massive fps drops.

[Necrolite]

Would it be feasible to add a bar that's just above the HP bars to show vendgeance? say, same width, that "fills" up as vengeance stacks? when there's no vengeance just collapses. perhaps some minimalistic text to show "current / max" attack power changing on the fly as your AP is changed?

i made a quick mockup in paint to illustrate what i meant, it's crude, forgive me

[PsiVen]

I think that placement would be distracting for actually seeing your Holy Power, but if I can find a configuration that seems sensible I'll look into it. Vengeance is a different animal so I hope there is a simpler API for it than just scanning player buffs.

I have thought about calculating the number for WoG/ShoR based on your current Holy Power and stats, but the more I considered that the more I realized it would be fairly useless and only a curiosity. A simple percentage for Vengeance could probably find itself useful though.

I am aware of a bug in the current version that will cause the spam errors again if you cast various glyphs whose spells are named the same as the cooldown spells they affect. Hopefully in fixing this one I will be able to prevent all the different machine-gun errors from cropping up again.

[Raeli]

I use this as my LUA text for Pitbull to show Vengeance stacks in the form of V:### and have it set to update on UNIT_AURA event.

It pretty much scans for the Vengeance buff, reads it's tooltip, and removes everything but the number, and then displays it.

Code: Select all

local WaV = CreateFrame( "GameTooltip", "WAV", nil, "GameTooltipTemplate" );
WaV:SetOwner( WorldFrame, "ANCHOR_NONE" );
local vengeanceon = UnitBuff("player", "Vengeance")
if vengeanceon then
WaV:SetUnitBuff("player", vengeanceon)
    local text = WAVTextLeft2:GetText()
    text = string.match(text, "%d+")
    return "V:" .. text   
end
WaV:Hide()

[Pollypally]

does this show holy shield?

[sealava]

one of the best tankadin addon in a long time.
however this my sound stupid ... but how can you move the bars ?

[Magnusharkov]

Thanks for the updates Psiven, I'm particularly liking the option for a sound effect on 3xholy power. A couple of requests:

1) Is it possible to add an option to boost the volume of the 3x holy power sound effect?
2) Would it also be doable to add a sound effect for Eternal Glory procs? I accept this is beginning to stray from the original minimal intent of the addon but I just thought I'd ask.

Thanks

[PsiVen]

Unfortunately that's impossible, as far as I know. The best I could do would be to package a really loud sound effect with the addon, which I don't really want to do for multiple sounds.

Eternal Glory procs have a sound effect already, don't they? Maybe that's just the regular WoG sound.

Sealava: First of the options is x/y coordinates.

[Xish]

Awesome addon, I was running the 1.0.4 release the first night I tried raiding in 4.0.1 and had to disable it b/c of machine-gun errors. I was completely lost w/o it! (DL'd new one and haven't had issues, TY!)

Just one request. I changed the size of the HoPo boxes to give them more of a golden ratio appearance, and I was fiddling w/ making them even larger, but I found if you make them larger, you get an odd black "fuzz" around the boxes that increases as you increase the HoPo box size. Would there be a way to add an option replace the default HoPo box frame with others, or would there be a way to adjust the current default frame so the "fuzz" would stop appearing at larger scales? Thanks again for the awesome addon!

[Necrolite]

I use this as my LUA text for Pitbull to show Vengeance stacks in the form of V:### and have it set to update on UNIT_AURA event.

It pretty much scans for the Vengeance buff, reads it's tooltip, and removes everything but the number, and then displays it.

Code: Select all

local WaV = CreateFrame( "GameTooltip", "WAV", nil, "GameTooltipTemplate" );
WaV:SetOwner( WorldFrame, "ANCHOR_NONE" );
local vengeanceon = UnitBuff("player", "Vengeance")
if vengeanceon then
WaV:SetUnitBuff("player", vengeanceon)
    local text = WAVTextLeft2:GetText()
    text = string.match(text, "%d+")
    return "V:" .. text   
end
WaV:Hide()

that seems pretty decent, although im fairly new to pitbull, where abouts are you putting this ?

[Yelena]

One thing I've noticed is that upon completion of a Battleground (I would presume this happens in Arenas as well given the same behavior), when everything freezes and the scorecard pops up, when you exit the BG itself the Holy Power bar will be stuck at whatever you had when the match ended. It'll stay that way until you start generating Holy Power events again (or reload the UI).

It doesn't spit out any lua errors when it does this, so I don't have an error log to show. I also haven't tested yet to see if this behavior is exhibited in any other Holy Power trackers (as I like how this one fits my overall UI layout).

[Yelena]

I use this as my LUA text for Pitbull to show Vengeance stacks in the form of V:### and have it set to update on UNIT_AURA event.

It pretty much scans for the Vengeance buff, reads it's tooltip, and removes everything but the number, and then displays it.

Code: Select all

local WaV = CreateFrame( "GameTooltip", "WAV", nil, "GameTooltipTemplate" );
WaV:SetOwner( WorldFrame, "ANCHOR_NONE" );
local vengeanceon = UnitBuff("player", "Vengeance")
if vengeanceon then
WaV:SetUnitBuff("player", vengeanceon)
    local text = WAVTextLeft2:GetText()
    text = string.match(text, "%d+")
    return "V:" .. text   
end
WaV:Hide()

Works like a charm, thanks.

[PsiVen]

One thing I've noticed is that upon completion of a Battleground (I would presume this happens in Arenas as well given the same behavior), when everything freezes and the scorecard pops up, when you exit the BG itself the Holy Power bar will be stuck at whatever you had when the match ended. It'll stay that way until you start generating Holy Power events again (or reload the UI).

It doesn't spit out any lua errors when it does this, so I don't have an error log to show. I also haven't tested yet to see if this behavior is exhibited in any other Holy Power trackers (as I like how this one fits my overall UI layout).

Interesting. My guess would be that this is caused by Holy Power decaying on the loading screen, so it ticks down without firing events until you do something with them. I could probably add an update trigger for changing zones that would fix this.

Just one request. I changed the size of the HoPo boxes to give them more of a golden ratio appearance, and I was fiddling w/ making them even larger, but I found if you make them larger, you get an odd black "fuzz" around the boxes that increases as you increase the HoPo box size. Would there be a way to add an option replace the default HoPo box frame with others, or would there be a way to adjust the current default frame so the "fuzz" would stop appearing at larger scales? Thanks again for the awesome addon!

I spent a little time fiddling with the frames when I added this feature and I haven't yet found where this texture's shape is actually defined. I would love to not have the stretch marks as soon as I can figure that out.

If anyone is still having machine-gun errors pop up the following causes are currently known:
- Holy Shock timer used (it bugs out when talents reset the CD too quickly); Workaround: Disable Holy Shock
- Glyphs cast whose spell names are the same as the spell they affect (Lay on Hands, Divine Protection, etc.); Workaround: ReloadUI after you reglyph

Please let me know if you're getting these errors under different conditions in 1.5.

[Autofollow]

I wanted to mention that I love this addon. However, has anyone been having any LUA errors with it?

Specifically, I'm having problems in Heroic Forge of Souls. Every time I run that zone my frame rate drops to about 4 or 5 fps, where I typically run about 60ish. Enabling LUA frames shows me an error for Holy Trinity. The only fix I've had for this is to reload my game every time, and it happens frequently. I think I reloaded in the neighborhood of 10 times last night before Brohnjam.

I don't normally complain, but I figure that you would want to know of any bugs that people have run into. Has anyone else seen this?

[Imminent]

First of all I love the addon and I much prefer using this as opposed to installing MoveAnything and moving the Blizzard UI for Holy Power. One thing I would ask if that if you can enhance the "Audio" function to be more like Hear Kitty (Then I can remove another addon from my list).

Hear Kitty will make sequential tones as you build and lose Holy Power as well as making a distinct sound letting you know when your HP stacks have been used. Louder tones are definitely better for when all the sound effects of raiding are happening.


Thanks alot for the addon.

[2Cute2BeStr8]

It seems like I can't get the CD timers to get bigger without making the holy power part of it bigger to. I just want the 3 little bars above my bartender, but when i do that all that i see is a very little cooldown timer and I'm like dang I can't seem to make that scale bigger cause it all scales under one option and then those holy power things get ginormous.

[PsiVen]

Hi guys, all errors should be squished this update:

-- v1.06 --
Fixed all instances of nil duration errors (hopefully)
Holy Power will now refresh properly after a loading screen
Removed LibBetterBlizzOptions

It seems like I can't get the CD timers to get bigger without making the holy power part of it bigger to. I just want the 3 little bars above my bartender, but when i do that all that i see is a very little cooldown timer and I'm like dang I can't seem to make that scale bigger cause it all scales under one option and then those holy power things get ginormous.

You can resize the Holy Power bars separately, so to get big cooldown timers turn up the scale and then shrink the Holy Power X/Y to the desired size. The texture on the bars might stretch a little when you do this, but it should be okay as long as you preserve the wide-rectangle shape.

[Vrimmel]

Could you change it so that we don't need to configure both sizes to change one? Also is there a way to increase the thickness of the cooldown timer bars?

[PsiVen]

Yes, but that requires separating the frames which I probably won't get to until I want to add mouse dragging and 'configuration mode' type features.