Remove Advertisements

"threat value" and EH modification of RatingBuster

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: "threat value" and EH modification of RatingBuster

Postby Gamingdevil » Mon Aug 24, 2009 3:39 am

Culhag wrote:
Gamingdevil wrote:I asked this in Theck's thread, but you must of missed it. Do you change the value of expertise for threat after the soft cap?

Yes. To quote the OP :
• Hit and Expertise will lose value when you get over the caps.
• BV and Str will lose value when you're over 2400 BV.


Whoops, sorry, I missed that. :oops:
If it is weak, kill it before it gets stronger. If it is strong, weaken it.
Image
User avatar
Gamingdevil
 
Posts: 1738
Joined: Mon Jan 14, 2008 8:16 am
Location: Belgium

Re: "threat value" and EH modification of RatingBuster

Postby Gamingdevil » Thu Aug 27, 2009 5:27 am

Say, while you're at it, do you think you can add an option to Ratingbuster to take BS sockets into account (and allow you to set a standard gem for prismatic sockets) It always annoys me when a piece seems worse than what I have, because it counts the extra gem on my current piece but doesn't take into account that I'll put one in the new one as well.
If it is weak, kill it before it gets stronger. If it is strong, weaken it.
Image
User avatar
Gamingdevil
 
Posts: 1738
Joined: Mon Jan 14, 2008 8:16 am
Location: Belgium

Re: "threat value" and EH modification of RatingBuster

Postby culhag » Thu Aug 27, 2009 8:22 am

That's way beyond my capability, but you could suggest that to the original author.
User avatar
culhag
Maintankadonor
 
Posts: 1729
Joined: Wed Aug 06, 2008 7:50 am
Location: France

Re: "threat value" and EH modification of RatingBuster

Postby culhag » Sat Aug 29, 2009 4:01 am

Updated using RatingBuster 1.4.6

http://www.mediafire.com/?ifmomeywymk
User avatar
culhag
Maintankadonor
 
Posts: 1729
Joined: Wed Aug 06, 2008 7:50 am
Location: France

Re: "threat value" and EH modification of RatingBuster

Postby Ragingsoul » Tue Sep 08, 2009 7:26 pm

nice mod man, I've been using it for a week or 2.
I had had a question through, how do you compare stamina vs armor for the EH line?
While tanking new content, one rule is important -- it's not about taking less damage; it's about being able to take more.
Image
Ragingsoul, Palatank, Tsunadee, Resto Druid, Bisoul, Mutilate Rogue
User avatar
Ragingsoul
 
Posts: 346
Joined: Sat Jul 26, 2008 10:01 pm

Re: "threat value" and EH modification of RatingBuster

Postby culhag » Wed Sep 09, 2009 3:28 am

To make it simple it's :
health from the object / (1 - damage reduction from the object's armor)
User avatar
culhag
Maintankadonor
 
Posts: 1729
Joined: Wed Aug 06, 2008 7:50 am
Location: France

Re: "threat value" and EH modification of RatingBuster

Postby Ragingsoul » Wed Sep 09, 2009 3:39 am

ok thank you.
While tanking new content, one rule is important -- it's not about taking less damage; it's about being able to take more.
Image
Ragingsoul, Palatank, Tsunadee, Resto Druid, Bisoul, Mutilate Rogue
User avatar
Ragingsoul
 
Posts: 346
Joined: Sat Jul 26, 2008 10:01 pm

Re: "threat value" and EH modification of RatingBuster

Postby theckhd » Wed Oct 07, 2009 12:39 pm

@culhag:
I've finally started work on the lua module. Here's a taste of what I have so far, unfortunately it will be slow going because I don't have a lot of time to code.

The basic idea is that it adds a function which calculates TPS on the fly by pulling information from the game's API. It still needs a lot of work, but mostly in the I/O department. The math is mostly finished, but I have to test the behavior of a lot of the API calls to make sure they're doing what I think they're doing.

The concept is that there would be two primary function calls:
TT:CalcTPS(), which calculates your TPS value
TT:SetExtras(), which would allow you to set the amount of "extra" STR, AGI, etc. that the CalcTPS function uses.

In other words, to find out how an item compares, you'd:
  • run SetExtras(0) to initialize them all to zero
  • run CalcTPS() to calculate your TPS in the current set of gear
  • run SetExtras() again, but with the differences the new item gives you (e.g. extraSTR=50, extraAGI=10, extraHit=-10, etc)
  • run CalcTPS() once more to computer the TPS in the new set of gear
  • Take the difference of the two results to determine the net TPS change

I'd really appreciate some help with this though - for one thing, it's been a long time since I've done much with the wow API, which means I end up having to look up every single function to figure out whether it does what I want. For another, I just don't have a lot of time to work on this stuff, so if I could con someone else into doing all of the window-dressing while I just keep the math portion updated, that would be swell.
Attachments
theck_threat.zip
skeleton threat module
(3.1 KiB) Downloaded 41 times
"Theck, Bringer of Numbers and Pounding Headaches," courtesy of Grehn|Skipjack.
MATLAB 5.x, Simcraft 6.x, Call to Arms 6.0, Talent Spec & Glyph Guide 5.x, Blog: Sacred Duty
User avatar
theckhd
Moderator
 
Posts: 7801
Joined: Thu Jul 31, 2008 3:06 pm
Location: Harrisburg, PA

Re: "threat value" and EH modification of RatingBuster

Postby Gamingdevil » Fri Oct 09, 2009 12:53 pm

Are you counting Weapon DPS for threat value?

I just got Honor of the Fallen while having Sorthalis, Hammer of the Watchers. While I have Sorthalis equipped and mouse over HotF, it says I lose some threat (50 or so). But while I have HotF equipped and mouse over Sorthalis, it says I would lose threat again (10 or so).

I'm quite sure I should be gaining threat from HotF with it having more strength and dps (Rawr supports me in this) but I'm confused...
If it is weak, kill it before it gets stronger. If it is strong, weaken it.
Image
User avatar
Gamingdevil
 
Posts: 1738
Joined: Mon Jan 14, 2008 8:16 am
Location: Belgium

Re: "threat value" and EH modification of RatingBuster

Postby towelliee » Thu Oct 22, 2009 3:49 am

so which is the link to show threat then? I have most recent from curse is this incorrect or do i have to use the one from the original post
towelliee
 
Posts: 1160
Joined: Tue May 27, 2008 8:09 am

Re: "threat value" and EH modification of RatingBuster

Postby culhag » Tue Oct 27, 2009 6:40 am

Shit, I haven't come here in a while. Sorry.

Theck, I'll try to include your module. It sounds like it should be good.
I had tried to code a bit myself, but having never coded anything I couldn't figure where to start...

I also had this idea of using the module in a more stand alone way, to display a "max theorical TPS" value on FuBar or LDB or just a chat output. That way you could switch gear around and see the value go up or down.
To go further, it could display two values: "current max TPS" and "raid buffed max TPS". We'd need to find which buffs the player already has, and add what's missing.
Again I couldn't really find how to do it myself.

Gamingdevil wrote:Are you counting Weapon DPS for threat value?

I just got Honor of the Fallen while having Sorthalis, Hammer of the Watchers. While I have Sorthalis equipped and mouse over HotF, it says I lose some threat (50 or so). But while I have HotF equipped and mouse over Sorthalis, it says I would lose threat again (10 or so).

I'm quite sure I should be gaining threat from HotF with it having more strength and dps (Rawr supports me in this) but I'm confused...

No, the current version doesn't count weapon dps, only the "normal" stats. I think the strange behavior must have come from the expertise on Sorthalis pushing you over the cap, or something.
Hopefully Theck's module should handle all that.
User avatar
culhag
Maintankadonor
 
Posts: 1729
Joined: Wed Aug 06, 2008 7:50 am
Location: France

Re: "threat value" and EH modification of RatingBuster

Postby _Chloe » Tue Oct 27, 2009 10:09 am

Here's a solution to one of your problems.

First make a table of expected buffs:
Code: Select all
local buffs = {
  1 = {"Mark of the Wild", 1337},
  2 = {"Gift of the Wild", 9001}
--Filler Key = {"Name of Buff", Rank},
}


Now use another table and UnitAura(); to see what buffs aren't there and store it:

Code: Select all
local playerNotBuffed = {}
for i = 1, table.getn(buffs) do
  local name, rank, _, _, _, _, _, _, _ = UnitAura("player",buffs.i.1, buffs.i.2);
  if name == nil or rank == nil table.insert(playerNotBuffed, buffs.i.1) else end
end


Now we have a table of buffs that are absent from your predefined list. Now just one more for loop for each type of buff and you're set. Remember to double check against group vs single buffs.

Code: Select all
for i = 1, table.getn(playerNotBuffed) do
  if playerNotBuffed.i == "Mark of the Wild" then
    local name, rank, _, _, _, _, _, _, _ = UnitAura("player","Gift of the Wild", 9001);
    if name == nil then AddMotWFunction() end
  else if playerNotBuffed.i == "Gift of the Wild" then
    local name, rank, _, _, _, _, _, _, _ = UnitAura("player","Mark of the Wild", 9001);
    if name == nil then AddMotWFunction() end
  end
end

--Clean-up
wipe(playerNotBuffed);



Just wait until the Tankadin3 lib is done. It already has the ability to create custom LDB objects as well as Lego Blocks.

Class Dismissed.
User avatar
_Chloe
Moderator
 
Posts: 971
Joined: Fri Dec 07, 2007 6:36 pm
Location: Santa Monica, CA

Re: "threat value" and EH modification of RatingBuster

Postby theckhd » Thu Nov 05, 2009 8:04 am

Yeah, I could see this all wrapped into a Tankadin3 module as well, if that's the direction culhag wants to take.

I haven't had much time to mess with it lately, but if someone does have time and figures out all of the necessary I/O calls, I'm more than willing to keep the threat module up to date.

I like the idea of placing a "TPS +/-" value in the tooltip of each item though, so you can quickly mouse over an item to figure out if it's a TPS increase or decrease. That could be done independently of RatingBuster though, and wouldn't require you to continually edit the latest version of RB to accomplish it.
"Theck, Bringer of Numbers and Pounding Headaches," courtesy of Grehn|Skipjack.
MATLAB 5.x, Simcraft 6.x, Call to Arms 6.0, Talent Spec & Glyph Guide 5.x, Blog: Sacred Duty
User avatar
theckhd
Moderator
 
Posts: 7801
Joined: Thu Jul 31, 2008 3:06 pm
Location: Harrisburg, PA

Re: "threat value" and EH modification of RatingBuster

Postby culhag » Mon Dec 21, 2009 6:12 pm

I haven't been able to make Theck's lib work yet,
so in the meantime I've updated the latest version of RatingBuster with fixed values like before.
(from Theck's 3.3 Stat Threat Analysis)

RatingBuster - Tankadin Edition for wow 3.3
User avatar
culhag
Maintankadonor
 
Posts: 1729
Joined: Wed Aug 06, 2008 7:50 am
Location: France

Re: "threat value" and EH modification of RatingBuster

Postby jathitimus » Thu Feb 18, 2010 2:41 pm

Firstly thanks a ton for making this addition to rating buster.

Unfornately the lastest verison you have patched in did not have the sacred duty changes in it, using what I found over here http://maintankadin.failsafedesign.com/forum/index.php?f=9&t=27839&rb_v=viewtopic (Thanks Shathus), I patched the stam change into the tankadin rating buster. Ive uploaded both the full addon (with change), and the updated lib file.

Lib:
http://www.mediafire.com/?t25uamj4ca2

Ratingbuster:
http://www.mediafire.com/?3jiq4mmymz5
"Human beings, who are almost unique in having the ability to learn from the experience of others, are also remarkable for their apparent disinclination to do so." - Douglas Adams
User avatar
jathitimus
 
Posts: 95
Joined: Wed Dec 17, 2008 12:46 am

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: No registered users and 1 guest


Remove Advertisements

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: No registered users and 1 guest
?php } else { ?