ThatJustHappened: Combat Event Announcement Mod

[fuzzygeek]

Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.

I had to change this:GetID() to self:GetID() instead in order to get the addon to work.

Instead? Isn't that what I have written?

[Arees]

Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.

I had to change this:GetID() to self:GetID() instead in order to get the addon to work.

Instead? Isn't that what I have written?

No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()

[fuzzygeek]

No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()

Oh wow. Fixed.

You'd think I'd have a better eye for code punctuation after all these years.

[Arees]

You'd think I'd have a better eye for code punctuation after all these years.

I've only just started getting into the LUA addon thing, and I find myself putting dots instead of colons and ending lines with a semi-colon... so it's understandable.

[majorwoo]

If someone wants to pm/email me the file I will be glad to host them for us until curse is (if) updated.

[fuzzygeek]

The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.

[Arees]

The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.

Pretty sure the mod never announced stacks. A while back Modus updated to code to do stack counting and posted it here.

I haven't had any issues with TJH after editing the source code.

**edit**
I guess I should say the official addon never announced stacks.

[fuzzygeek]

Hmm, I've never used Modus' fork, and I used to announce phase punch, puppy bites, fester stacks and the like.

Also, I reverted to the version I was using in 3.x that did stack announcements and applied the 4.x code fixes, and the announces (other than the initial effect) stopped.

[Sarkan-ZdC]

Anybody got it to working for 4.0+ and can upload it somewhere?

[Arees]

Anybody got it to working for 4.0+ and can upload it somewhere?

If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.

[Sarkan-ZdC]

Anybody got it to working for 4.0+ and can upload it somewhere?

If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.

I got you a PM but if somebody else can upload it somewhere (rapidshare.com) I would be very grateful

[theothersteve7]

I intend to crack this open sometime tomorrow. Given Blizzard's rules about what rights you have when you author an addon, I can probably just throw the branch up on Curse, right? I've never done anything like that before, just asking.

Oh. Unless, is Modus the author? I should check who the author is.

I was kind of famous for using this mod in Wrath, and I really miss it. You can do some very clever things with it. Also, I learned that using it directly for Divine Guardian is a bad idea - it announces it once for each member of your raid >_<

[Sarkan-ZdC]

Original Author: http://www.curseforge.com/profiles/belleboom/

Did not update any of his mods for more then a year.

Usually it is done that you call the new mod something like "TJH reloaded" and say in the description that you only fixed the original mod found here.
Happens a los with mods.

And I still would be eternaly grateful

[Arees]

I had more people PM me for my modified version of TJH that I thought I would have. I haven't answered because I was away for Christmas and didn't have access to my PC. Now that I'm home I have uploaded the modified version of it here.

[Sarkan-ZdC]

Thank you very much!