Remove Advertisements

ThatJustHappened: Combat Event Announcement Mod

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Sun Nov 07, 2010 6:03 pm

Pyched wrote:
fuzzygeek wrote:Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.


I had to change this:GetID() to self:GetID() instead in order to get the addon to work.


Instead? Isn't that what I have written?
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5085
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sun Nov 07, 2010 6:36 pm

fuzzygeek wrote:
Pyched wrote:
fuzzygeek wrote:Do a search-and-replace for: this:GetID()
Replace it with: self.GetID()

There should be 49 occurances.
And you should be good to go.


I had to change this:GetID() to self:GetID() instead in order to get the addon to work.


Instead? Isn't that what I have written?


No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Nov 08, 2010 10:01 am

WATERBOYsh wrote:No.. you used a dot operator.... self.GetID() instead of using a colon, self:GetID()


Oh wow. Fixed.

You'd think I'd have a better eye for code punctuation after all these years.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5085
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Nov 08, 2010 5:54 pm

fuzzygeek wrote:You'd think I'd have a better eye for code punctuation after all these years.


I've only just started getting into the LUA addon thing, and I find myself putting dots instead of colons and ending lines with a semi-colon... so it's understandable.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby majorwoo » Tue Nov 09, 2010 8:28 am

If someone wants to pm/email me the file I will be glad to host them for us until curse is (if) updated.
Image
Despite all my rage, I am still just a Paladin Tank.
User avatar
majorwoo
 
Posts: 478
Joined: Tue May 20, 2008 7:24 am
Location: Atlanta, GA, USA

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Nov 09, 2010 9:46 am

The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5085
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Tue Nov 09, 2010 1:25 pm

fuzzygeek wrote:The mod is no longer announcing stacks, and I've found a few other oddities. When I get a chance to fix I'll go and post a branch on wowinterface.


Pretty sure the mod never announced stacks. A while back Modus updated to code to do stack counting and posted it here.

I haven't had any issues with TJH after editing the source code.

**edit**
I guess I should say the official addon never announced stacks.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Nov 09, 2010 2:34 pm

Hmm, I've never used Modus' fork, and I used to announce phase punch, puppy bites, fester stacks and the like.

Also, I reverted to the version I was using in 3.x that did stack announcements and applied the 4.x code fixes, and the announces (other than the initial effect) stopped.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 5085
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Mon Dec 13, 2010 10:08 am

Anybody got it to working for 4.0+ and can upload it somewhere?
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Mon Dec 13, 2010 4:11 pm

Sarkan-ZdC wrote:Anybody got it to working for 4.0+ and can upload it somewhere?


If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Tue Dec 21, 2010 5:50 pm

Arees wrote:
Sarkan-ZdC wrote:Anybody got it to working for 4.0+ and can upload it somewhere?


If you want to pm me with your e-mail address I can mail you my modified lua and xml file. If you want to do it yourself, check back maybe 1 or 2 pages in the thread with how to do it.


I got you a PM but if somebody else can upload it somewhere (rapidshare.com) I would be very grateful
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby theothersteve7 » Wed Dec 22, 2010 1:41 pm

I intend to crack this open sometime tomorrow. Given Blizzard's rules about what rights you have when you author an addon, I can probably just throw the branch up on Curse, right? I've never done anything like that before, just asking.

Oh. Unless, is Modus the author? I should check who the author is.

I was kind of famous for using this mod in Wrath, and I really miss it. You can do some very clever things with it. Also, I learned that using it directly for Divine Guardian is a bad idea - it announces it once for each member of your raid >_<
Moo.
theothersteve7
 
Posts: 402
Joined: Tue Nov 25, 2008 11:45 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Thu Dec 23, 2010 6:39 am

Original Author: http://www.curseforge.com/profiles/belleboom/

Did not update any of his mods for more then a year.

Usually it is done that you call the new mod something like "TJH reloaded" and say in the description that you only fixed the original mod found here.
Happens a los with mods.

And I still would be eternaly grateful :)
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Sun Dec 26, 2010 6:55 pm

I had more people PM me for my modified version of TJH that I thought I would have. I haven't answered because I was away for Christmas and didn't have access to my PC. Now that I'm home I have uploaded the modified version of it here.
Image
User avatar
Arees
 
Posts: 546
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Sarkan-ZdC » Mon Dec 27, 2010 3:31 pm

Thank you very much!
Sarkan-ZdC
 
Posts: 699
Joined: Tue May 13, 2008 4:00 am

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: No registered users and 1 guest


Remove Advertisements

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: No registered users and 1 guest