ThatJustHappened: Combat Event Announcement Mod

All things /script related

Moderators: Fridmarr, Worldie, Aergis, _Chloe

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Meebo » Sat Mar 06, 2010 10:50 pm

I've been doing a little investigating into why some of the mods I use where stuffing up and got around to doing some full taint logging; "/console taintLog 2" command, and I got this with TJH:

Code: Select all
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
3/7 15:45:51.534  Global variable TJH_timeDelay tainted by ThatJustHappened - Interface\AddOns\ThatJustHappened\ThatJustHappened.lua:218 TJH_OnEvent()
3/7 15:45:51.534      ThatJustHappened:OnEvent()
Image
Meebo
 
Posts: 8
Joined: Fri May 15, 2009 11:47 pm
Location: Australia

Re: ThatJustHappened: Combat Event Announcement Mod

Postby chinoquezada » Wed Apr 21, 2010 2:16 pm

Kinda thread-necro. But I really find this addon extremely useful for my raids.
User avatar
chinoquezada
 
Posts: 68
Joined: Thu Jun 19, 2008 2:47 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Thu Apr 22, 2010 11:49 am

chinoquezada wrote:Kinda thread-necro. But I really find this addon extremely useful for my raids.


Me too. The dps in my raids tend to develop tunnel vision and ignore the environment, so I set it up to whisper people on fights such as Jaraxxus when they get legion flame, when they are being pursued by anub, or festergut when they become a spore, and especially on rotface to let them know they are infected and to run to me since I kite the big ooze around.

Thats just a few examples, but I have a ton of rules that I create as I see a need for them. A few more simple ones I did is announce in /rw when a fish feast or jeeves has been dropped.
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby hellomynameis » Thu May 20, 2010 6:30 am

Hi all, I just wanted to post the rules on my Paladin, you might find someone them helpful for pvp.
Code: Select all
TJH_Rules = {
   "SPELL_CAST;Moorabi;;Transformation;;SAY;Interrupt it!;", -- [1]
   "SPELL_MISSED;Buffer;;Righteous Defense;self;RAID_WARNING;Taunt failed on *target.;", -- [2]
   "SPELL_CAST_SUCCESS;;Buffer;Righteous Defense;;SELF;*source taunted from me.;", -- [3]
   "SPELL_CAST_SUCCESS;;;Divine Intervention;raid;SELF;*source has cast *spell on *target!;", -- [4]
   "SPELL_CAST_START;;;Redemption;self;AUTO;Rezzing %t;", -- [5]
   "SPELL_AURA_APPLIED;Buffer;;Nitro Boosts;;EMOTE;sprints like a maniac;", -- [6]
   "SPELL_AURA_APPLIED;Buffer;Buffer;Avenging Wrath;;EMOTE;/train;", -- [7]
   "SPELL_CAST_START;Kael'thas;;Pyroblast;;YELL;INC PYROBLAST!;", -- [8]
   "SPELL_AURA_APPLIED;;Buffer;Polymorph;;WUBBZY;I'm a sheep.;", -- [9]
   "SPELL_AURA_APPLIED;;Buffer;Freezing Trap;;WUBBZY;I'm cold.;", -- [10]
   "SPELL_AURA_APPLIED;;Buffer;Sap;;YELL;Sapped.;", -- [11]
   "SPELL_DISPEL;;;Divine Shield;Target;PARTY;Bubble dispelled from *target, ty *source.;", -- [12]
   "SPELL_DISPEL_FAILED;;;Divine Shield;Target;PARTY;Dispelling *spell failed;", -- [13]
   "SPELL_DISPEL;;;Divine Protection;Target;PARTY;Bubble dispelled from *target, ty *source.;", -- [14]
   "SPELL_DISPEL_FAILED;;;Divine Protection;Target;PARTY;Dispelling *spell failed;", -- [15]
   "SPELL_DISPEL;;;Hand of Protection;Target;PARTY;Bubble dispelled from *target, ty *source.;", -- [16]
   "SPELL_DISPEL_FAILED;;;Hand of Protection;Target;PARTY;Dispelling *spell failed;", -- [17]
   "SPELL_AURA_APPLIED;Buffer;;Hand of Protection;;*TARGET;I gave you *spell!;", -- [18]
   "SPELL_CAST_START;;Wubbzy;Mana Burn;;YELL;*source is Mana burning *target!;", -- [19]
   "SPELL_CAST_START;;Wubbzy;Mana Burn;;*TARGET;You're getting Mana Burned by *source!;", -- [20]
   "SPELL_CAST_START;;Foom;Mana Burn;;YELL;*source is Mana burning *target!;", -- [21]
   "SPELL_CAST_START;;Foom;Mana Burn;;*TARGET;You're getting Mana Burned by *source!;", -- [22]
   "SPELL_AURA_APPLIED;;Buffer;Intimidating Shout;;YELL;I'm scared by *spell!;", -- [23]
   "SPELL_AURA_APPLIED;;Buffer;65543;;YELL;I'm scared by *spell!;", -- [24]
   "SPELL_AURA_APPLIED;;Buffer;6215;;YELL;I'm scared by *spell!;", -- [25]
   "SPELL_AURA_APPLIED;;Buffer;Howl of Terror;;YELL;I'm scared by *spell!;", -- [26]
   "SPELL_AURA_APPLIED;Buffer;Wubbzy;Hand of Freedom;;*TARGET;You got *spell! Run! Run!;", -- [27]
   "SPELL_AURA_APPLIED;Buffer;Wrakk;Hand of Freedom;;*TARGET;You got *spell! Run! Run!;", -- [28]
   "SPELL_AURA_APPLIED;Buffer;Foom;Hand of Freedom;;*TARGET;You got *spell! Run! Run!;", -- [29]
   "SPELL_AURA_APPLIED;Buffer;Gizminator;Hand of Freedom;;*TARGET;You got *spell! Run! Run!;", -- [30]
   "SPELL_AURA_APPLIED;Buffer;Crazygizka;Hand of Freedom;;*TARGET;You got *spell! Run! Run!;", -- [31]
   "SPELL_AURA_APPLIED;;;Divine Shield;enemy;YELL;Paladin used Divine Shield(12secs), swap target!;", -- [32]
   "SPELL_AURA_APPLIED;;;Dispersion;enemy;YELL;Shadowpriest used Dispersion(6secs), swap target!;", -- [33]
   "SPELL_AURA_APPLIED;;;Divine Protection;enemy;YELL;Paladin used Divine Protection(12secs), swap target!;", -- [34]
   "SPELL_AURA_APPLIED;;;Hand of Protection;enemy;YELL;Hand of Protection(10secs) on *target , swap target!;", -- [35]
   "SPELL_AURA_APPLIED;;;Evasion;enemy;YELL;Rogue used Evasion(15secs), swap target!;", -- [36]
   "SPELL_AURA_APPLIED;;;Anti-Magic Shell;enemy;YELL;Death Knight used Anti-Magic Shell(5secs), hold nuke for 5 secs!;", -- [37]
   "SPELL_AURA_APPLIED;;;Shield Wall;enemy;YELL;Warrior used Shield Wall(12secs), swap target!;", -- [38]
   "SPELL_AURA_APPLIED;;;Shield Block;enemy;YELL;Warrior used Shield Block(10secs), swap target!;", -- [39]
   "SPELL_AURA_APPLIED;;;Deterrence;enemy;YELL;Hunter used Deterrence(5secs), hold nuke for 5 secs!;", -- [40]
   "SPELL_AURA_APPLIED;;;Ice Block;enemy;YELL;Mage used Ice Block(10secs), swap target!;", -- [41]
   "SPELL_AURA_APPLIED;;;Pain Suppression;enemy;YELL;Pain Suppression(8secs)on *target, swap target!;", -- [42]
   "SPELL_AURA_APPLIED;;;Barkskin;enemy;YELL;Druid used Barkskin(12secs), swap target!;", -- [43]
   "SPELL_AURA_APPLIED;;;Hand of Salvation;enemy;YELL;Paladin used Hand of Salvation(10secs), swap target!;", -- [44]
   "SPELL_AURA_APPLIED;;;Hand of Sacrifice;enemy;YELL;Hand of Sacrifice(12secs) on *target, swap target!;", -- [45]
   "SPELL_AURA_APPLIED;;;Shamanistic Rage;enemy;YELL;Shaman used Shamanistic Rage(15secs), swap target!;", -- [46]
   "SPELL_AURA_APPLIED;;;Icebound Fortitude;enemy;YELL;Death Knight used Icebound Fortitude(12secs), swap target!;", -- [47]
   "SPELL_AURA_APPLIED;;;Cloak of Shadows;enemy;YELL;Rogue used Cloak of Shadows(5secs), hold nuke for 5 secs!;", -- [48]
   "SPELL_AURA_APPLIED;;;Vampiric Blood;enemy;YELL;Death Knight used Vampiric Blood(10secs), CC him!;", -- [49]
   "SPELL_AURA_APPLIED;;;Frenzied Regeneration;enemy;YELL;Druid used Frenzied Regeneration(10secs), swap target!;", -- [50]
   "SPELL_AURA_APPLIED;;;Invisibility;enemy;YELL;Mage used Invisibility(20secs)!;", -- [51]
   "SPELL_AURA_APPLIED;;;Vanish;enemy;YELL;Rogue used Vanish!;", -- [52]
   "SPELL_AURA_REMOVED;;;Divine Shield;enemy;YELL;Divine Shield over, nuke Paladin!;", -- [53]
   "SPELL_AURA_REMOVED;;;Dispersion;enemy;YELL;Dispersion over, nuke Shadowpriest!;", -- [54]
   "SPELL_AURA_REMOVED;;;Divine Protection;enemy;YELL;Divine Protection over, nuke Paladin!;", -- [55]
   "SPELL_AURA_REMOVED;;;Hand of Protection;enemy;YELL;Hand of Protection over, nuke *target!;", -- [56]
   "SPELL_AURA_REMOVED;;;Evasion;enemy;YELL;Evasion over, nuke Rogue!;", -- [57]
   "SPELL_AURA_REMOVED;;;Anti-Magic Shell;enemy;YELL;Anti-Magic Shell over, nuke Death Knight!;", -- [58]
   "SPELL_AURA_REMOVED;;;Shield Wall;enemy;YELL;Shield Wall over, nuke Warrior!;", -- [59]
   "SPELL_AURA_REMOVED;;;Shield Block;enemy;YELL;Shield Block over, nuke Warrior!;", -- [60]
   "SPELL_AURA_REMOVED;;;Deterrence;enemy;YELL;Deterrence over, nuke Hunter!;", -- [61]
   "SPELL_AURA_REMOVED;;;Ice Block;enemy;YELL;Ice Block over, nuke Mage!;", -- [62]
   "SPELL_AURA_REMOVED;;;Pain Suppression;enemy;YELL;Pain Suppression over, nuke *target!;", -- [63]
   "SPELL_AURA_REMOVED;;;Barkskin;enemy;YELL;Barkskin over, nuke Druid!;", -- [64]
   "SPELL_AURA_REMOVED;;;Hand of Salvation;enemy;YELL;Hand of Salvation over, nuke Paladin!;", -- [65]
   "SPELL_AURA_REMOVED;;;Hand of Sacrifice;enemy;YELL;Hand of Sacrifice over, nuke *target!;", -- [66]
   "SPELL_AURA_REMOVED;;;Shamanistic Rage;enemy;YELL;Shamanistic Rage over, nuke Shaman!;", -- [67]
   "SPELL_AURA_REMOVED;;;Icebound Fortitude;enemy;YELL;Icebound Fortitude over, nuke Death Knight!;", -- [68]
   "SPELL_AURA_REMOVED;;;Cloak of Shadows;enemy;YELL;Cloak of Shadows over, nuke Rogue!;", -- [69]
   "SPELL_AURA_REMOVED;;;Vampiric Blood;enemy;YELL;Vampiric Blood over, nuke Death Knight!;", -- [70]
   "SPELL_AURA_REMOVED;;;Frenzied Regeneration;enemy;YELL;Frenzied Regeneration over, nuke Druid!;", -- [71]
   "SPELL_AURA_REMOVED;;;Invisibility;enemy;YELL;Mage is visible again, nuke!;", -- [72]
}


Some of them is about whispering teammates in arena 5v5, some are just plain yelling out when we should switch nuketargets. Some of the first ones are from this thread, but about 60 of them are "homemade".
I found that yelling when people use defensive CD and when its over, gets very spammy in battlegrounds. :) But hey, they work great in arena atleast.
hellomynameis
 
Posts: 2
Joined: Wed Oct 21, 2009 6:21 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby qdesh » Sun Jul 25, 2010 8:16 am

Hi

Is this addon working after latest patch (Ruby Sanctum one)?

I tried today but i gave up after 1 hour trying.

/Q
qdesh
 
Posts: 1
Joined: Thu Sep 10, 2009 2:39 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Tue Oct 12, 2010 5:32 am

Hopefully they have not changes the format of the combat log and this addon still works... I love this addon =D
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Thu Oct 14, 2010 12:10 am

WATERBOYsh wrote:Hopefully they have not changes the format of the combat log and this addon still works... I love this addon =D


Right now it is broken. I hope it gets updated, because it is made out of concentrated awesome.

If it's not being maintained, I'll fix it myself.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby dukka » Thu Oct 14, 2010 1:23 am

If someone with the proper skills manages to fix it, even if it's just an ugly hack, I'd love it to be posted here :)
dukka
 
Posts: 4
Joined: Fri Sep 26, 2008 3:34 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Arees » Thu Oct 14, 2010 7:58 am

I was just about to come post myself that this awesome mod is not working =(
Image
User avatar
Arees
 
Posts: 301
Joined: Tue Dec 25, 2007 9:50 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby dukka » Sat Oct 16, 2010 4:55 am

I managed to get it to work, but since I have no idea what I'm doing, someone who does should fix it instead properly

Here's what I _think_ was wrong:

ThatJustHappened.xml has references to this, they need to go and be replaced by references to self instead
ThatJustHappened.lua needs to have a variable added to accept this new reference to self, and then attach events to that instead of this

the onEvent function somehow before got arguments magically to appear in arg2, arg4 etc (I have no idea), apparently the pixies that did that no longer does that, so argument values has to be manually assigned.

Hopefully some ninja addon coder can quickly fix it now, if I can help by making the above or below clearer, drop a pm or post, would be ace to have it properly fixed...

I repeat, I have no idea what I'm doing here, really, sorry.

Cheers,

dukka


snips that should allow you to almost fix things yourself:

in lua:


-- added variable to accept the "self" object
function TJH_OnLoad(frame)


-- use variable as (whatever) to register event to
frame:RegisterEvent("VARIABLES_LOADED");
frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");


-- added variable to accept the "self" object
function TJH_OnEvent(frame, event, ...)

-- put these lines of code before the checks for nil values for arg2, arg4 etc
if (select(2, ...) ~= nil) then arg2 = select(2, ...); end
if (select(4, ...) ~= nil) then arg4 = select(4, ...); end
if (select(5, ...) ~= nil) then arg5 = select(5, ...); end
if (select(7, ...) ~= nil) then arg7 = select(7, ...); end
if (select(8, ...) ~= nil) then arg8 = select(8, ...); end
if (select(9, ...) ~= nil) then arg9 = select(9, ...); end
if (select(10, ...) ~= nil) then arg10 = select(10, ...); end
if (select(11, ...) ~= nil) then arg11 = select(11, ...); end
if (select(12, ...) ~= nil) then arg12 = select(12, ...); end


in xml:

<OnLoad>TJH_OnLoad(self);</OnLoad>
<OnEvent>TJH_OnEvent(self, event, ...);</OnEvent>

and search for this and replace with self




edit: updated the if block fixing typo, possibly all the "if..." are not required, I'm just not sure there's always a value in there...
Last edited by dukka on Sat Oct 16, 2010 10:07 pm, edited 1 time in total.
70 - eu shadowsong
dukka
 
Posts: 4
Joined: Fri Sep 26, 2008 3:34 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Sat Oct 16, 2010 10:00 am

These fixes work and I appear to be functional again -- thank you!

I had gotten the thing to stop erroring by changing the "this" references and cross-referencing how other mods used OnLoad events, but could not get it to output until I added the "if" block you have here. How did you know this code was necessary?

Not to mention the code block uses "nill" (vs nil) which doesn't make sense to me

Although changing it to "nil" doesn't seem to have any effect (still works).

Hmm.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby dukka » Sat Oct 16, 2010 10:05 pm

I had no idea it would work, I spent some time using the "print" statement to figure out where it went wrong, I would still love to know why it worked before :)

good catch about nill vs nil, that's just an error on my end, updated the earlier post with it, I'm not even sure the check is necessary I just put it there because during my "printing" trying to assign a nil value to something broke the code
70 - eu shadowsong
dukka
 
Posts: 4
Joined: Fri Sep 26, 2008 3:34 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Mon Oct 18, 2010 5:02 am

fuzzygeek wrote:If it's not being maintained, I'll fix it myself.

Please do, I had this mod back in BC and it was awesome. With blizz trying to make the game hard again I may find some more uses for it in the future. If I had any programming knowledge at all I'd try and fix it myself :(
Echaa
 
Posts: 44
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Tntmax » Mon Oct 18, 2010 7:31 am

God bless you for your workaround Dukka!

I just registered here to say a thank, so thank you! :-)
Tntmax
 
Posts: 1
Joined: Mon Oct 18, 2010 7:28 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Oct 18, 2010 8:36 am

Echaa wrote:
fuzzygeek wrote:If it's not being maintained, I'll fix it myself.

Please do, I had this mod back in BC and it was awesome. With blizz trying to make the game hard again I may find some more uses for it in the future. If I had any programming knowledge at all I'd try and fix it myself :(


Dukka's post above will get you back up and running; I suppose we should make it available on curse if the project owner doesn't pick it up?
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Pyched » Mon Oct 18, 2010 11:30 am

I am quite useless when it comes to understanding code. If it's not too inconvenient, please let me know exactly where I add each of those lines in the Lua and xml files. Alternatively, it might just be easier for me to wait for the edited files to be made available. Any help will be appreciated!
Pyched
 
Posts: 4
Joined: Mon Oct 18, 2010 11:10 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Mon Oct 18, 2010 5:52 pm

Pyched wrote:I am quite useless when it comes to understanding code. If it's not too inconvenient, please let me know exactly where I add each of those lines in the Lua and xml files. Alternatively, it might just be easier for me to wait for the edited files to be made available. Any help will be appreciated!

I'm in the same boat, unfortunately ctrl+f and copy/paste can only do so much. I wasn't able to find half of the arg# segments and I had no idea what to do for the preceding steps.
Echaa
 
Posts: 44
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Mon Oct 18, 2010 6:47 pm

You'll need a text editor, such as notepad. Notepad2 is even better, since it'll support line numbers and stuff.

In ThatJustHappened.xml:

Line 7 looks like:
Code: Select all
this:SetOwner(UIParent, "ANCHOR_NONE");

Change it to:
Code: Select all
self:SetOwner(UIParent, "ANCHOR_NONE");


Lines 12-17 look like:
Code: Select all
   <Frame name="ThatJustHappened" visible="true" parent="UIParent">
      <Scripts>
         <OnLoad>TJH_OnLoad();</OnLoad>
         <OnEvent>TJH_OnEvent(this, event, ...);</OnEvent>
      </Scripts>
   </Frame>

You'll want to change lines 14 and 15 to read:
Code: Select all
         <OnLoad>TJH_OnLoad(self);</OnLoad>
         <OnEvent>TJH_OnEvent(self, event, ...);</OnEvent>


Line 273
Code: Select all
EasyMenu(TJHevent_menuList, this, "TJH_RuleEventBox", 245, 245);

change to:
Code: Select all
EasyMenu(TJHevent_menuList, self, "TJH_RuleEventBox", 245, 245);


Line 598
Code: Select all
EasyMenu(TJHclass_menuList, this, "TJH_RuleAffiliationBox", 170, 50);

change to:
Code: Select all
EasyMenu(TJHclass_menuList, self, "TJH_RuleAffiliationBox", 170, 50);


Line 1648
Code: Select all
this:RegisterForDrag("LeftButton");

change to:
Code: Select all
self:RegisterForDrag("LeftButton");


Line 1675-1676
Code: Select all
<OnDragStart>this:StartMoving();this.isMoving = true;</OnDragStart>
<OnDragStop>this:StopMovingOrSizing();this.isMoving = false;</OnDragStop>

change to:
Code: Select all
<OnDragStart>self:StartMoving();self.isMoving = true;</OnDragStart>
<OnDragStop>self:StopMovingOrSizing();self.isMoving = false;</OnDragStop>


Save the file, close it.

Open the ThatJustHappened.lua file.

Line 108
Code: Select all
function TJH_OnLoad()

change to:
Code: Select all
function TJH_OnLoad(frame)


Lines 114-115
Code: Select all
   this:RegisterEvent("VARIABLES_LOADED");
   this:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");

change to:
Code: Select all
   frame:RegisterEvent("VARIABLES_LOADED");
   frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");


Line 143:
Code: Select all
this:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED");

change to:
Code: Select all
self:UnregisterEvent("COMBAT_LOG_EVENT_UNFILTERED");


Line 191
Code: Select all
function TJH_OnEvent(event, ...)

change to
Code: Select all
function TJH_OnEvent(frame, event, ...)


Look for lines 208 to 213. Looks like this:
Code: Select all
   if arg2 == nil then arg2 = ""; end
   if arg4 == nil then arg4 = ""; end
   if arg7 == nil then arg7 = ""; end
   if arg9 == nil then arg9 = ""; end
   if arg10 == nil then arg10 = ""; end
   if arg12 == nil then arg12 = ""; end


Insert these lines IN FRONT OF this block so it looks like:
Code: Select all
   if (select(2, ...) ~= nil) then arg2 = select(2, ...); end
   if (select(4, ...) ~= nil) then arg4 = select(4, ...); end
   if (select(5, ...) ~= nil) then arg5 = select(5, ...); end
   if (select(7, ...) ~= nil) then arg7 = select(7, ...); end
   if (select(8, ...) ~= nil) then arg8 = select(8, ...); end
   if (select(9, ...) ~= nil) then arg9 = select(9, ...); end
   if (select(10, ...) ~= nil) then arg10 = select(10, ...); end
   if (select(11, ...) ~= nil) then arg11 = select(11, ...); end
   if (select(12, ...) ~= nil) then arg12 = select(12, ...); end

   if arg2 == nil then arg2 = ""; end
   if arg4 == nil then arg4 = ""; end
   if arg7 == nil then arg7 = ""; end
   if arg9 == nil then arg9 = ""; end
   if arg10 == nil then arg10 = ""; end
   if arg12 == nil then arg12 = ""; end


Do a search-and-replace for: this:GetID()
Replace it with: self:GetID()

There should be 49 occurances.

Save the file.

And you should be good to go.
Last edited by fuzzygeek on Mon Nov 08, 2010 10:01 am, edited 2 times in total.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Tue Oct 19, 2010 12:30 am

I went through everything you suggested and the game doesn't recognize /tjh as a command.

I initially tried to follow Dukka's instructions and didn't get it to work so I tried restoring my backup xml/lua files. After using your guide and it failing to register, I deleted and reinstalled it and followed the steps you gave again to no avail. One thing that looked suspicious is the line 9-10 suggestion, it looked to me like the lines you said to paste in were already there. I'm also a little confused on how to do the lua lines 208-213.

Right now my lua file looks like
Code: Select all
   208 if (select(2, ...) ~= nil) then arg2 = select(2, ...); end
   209 if (select(4, ...) ~= nil) then arg4 = select(4, ...); end
   210 if (select(5, ...) ~= nil) then arg5 = select(5, ...); end
   211 if (select(7, ...) ~= nil) then arg7 = select(7, ...); end
   212 if (select(8, ...) ~= nil) then arg8 = select(8, ...); end
   213 if (select(9, ...) ~= nil) then arg9 = select(9, ...); end
   214 if (select(10, ...) ~= nil) then arg10 = select(10, ...); end
   215 if (select(11, ...) ~= nil) then arg11 = select(11, ...); end
   216 if (select(12, ...) ~= nil) then arg12 = select(12, ...); end
   217
   218 if arg2 == nil then arg2 = ""; end
   219 if arg4 == nil then arg4 = ""; end
   220 if arg7 == nil then arg7 = ""; end
   221 if arg9 == nil then arg9 = ""; end
   222 if arg10 == nil then arg10 = ""; end
   223 if arg12 == nil then arg12 = ""; end

Is this correct? I'm not sure if I should put the new lines in front of
Code: Select all
if arg2 == nil then arg2 = ""; end
or above it.
I'm wondering if its
Code: Select all
if (select(2, ...) ~= nil) then arg2 = select(2, ...); end if arg2 == nil then arg2 = ""; end
ect..
or
Code: Select all
    if (select(2, ...) ~= nil) then arg2 = select(2, ...); end
    if (select(4, ...) ~= nil) then arg4 = select(4, ...); end
     ect...

    if arg2 == nil then arg2 = ""; end
    if arg4 == nil then arg4 = ""; end
    ...
Echaa
 
Posts: 44
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Oct 19, 2010 12:59 am

Echaa wrote:I went through everything you suggested and the game doesn't recognize /tjh as a command.

I initially tried to follow Dukka's instructions and didn't get it to work so I tried restoring my backup xml/lua files. After using your guide and it failing to register, I deleted and reinstalled it and followed the steps you gave again to no avail. One thing that looked suspicious is the line 9-10 suggestion, it looked to me like the lines you said to paste in were already there. I'm also a little confused on how to do the lua lines 208-213.


Line 9&10 add "self" references.

<OnLoad>TJH_OnLoad(self);</OnLoad>
<OnEvent>TJH_OnEvent(self, event, ...);</OnEvent>


You've pasted the lines in correctly, with 208-216 being "if (select(2, ...) ~= nil) then arg2 = select(2, ...); end" etc, and 218 etc being the existing block.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Tue Oct 19, 2010 2:43 am

fuzzygeek wrote:
Echaa wrote:I went through everything you suggested and the game doesn't recognize /tjh as a command.

I initially tried to follow Dukka's instructions and didn't get it to work so I tried restoring my backup xml/lua files. After using your guide and it failing to register, I deleted and reinstalled it and followed the steps you gave again to no avail. One thing that looked suspicious is the line 9-10 suggestion, it looked to me like the lines you said to paste in were already there. I'm also a little confused on how to do the lua lines 208-213.


Line 9&10 add "self" references.

<OnLoad>TJH_OnLoad(self);</OnLoad>
<OnEvent>TJH_OnEvent(self, event, ...);</OnEvent>


You've pasted the lines in correctly, with 208-216 being "if (select(2, ...) ~= nil) then arg2 = select(2, ...); end" etc, and 218 etc being the existing block.


My XML line 9-10 are:
Code: Select all
</Scripts>
</GameTooltip>


Reading Notepad(regular) was absolutely impossible so I got Notepad2, which I'm assuming is what you're using. I'm not seeing the lines you mention anywhere near 9 or 10. I know nothing about programming but I've got a hinting suspicion that removing the text on those two lines will break some scripts seeing as <Scripts> and <OnLoad> appear on lines 5 and 6 respectively followed by line 7, "this:SetOwner(UIParent, "ANCHOR_NONE");".
Echaa
 
Posts: 44
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Oct 19, 2010 8:11 am

What about references to TJH_Onload?

Are you using the file currently posted on Curse? The snippets posted were done on a fresh download last night.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby Echaa » Tue Oct 19, 2010 8:21 am

fuzzygeek wrote:What about references to TJH_Onload?

Are you using the file currently posted on Curse? The snippets posted were done on a fresh download last night.

Yes, I'm using 3.0.5.2 from the Curse updater. I opened my XML file and
Code: Select all
<OnLoad>TJH_OnLoad();</OnLoad>
<OnEvent>TJH_OnEvent(this, event, ...);</OnEvent>

popped right out at me, though they're on lines 14 and 15. I changed them to:
Code: Select all
<OnLoad>TJH_OnLoad(self);</OnLoad>
<OnEvent>TJH_OnEvent(self, event, ...);</OnEvent>

I'll test it out again when the server comes up.

Does what line they're on have any bearing at all on what their function is?
Echaa
 
Posts: 44
Joined: Wed Jun 04, 2008 10:24 pm

Re: ThatJustHappened: Combat Event Announcement Mod

Postby tobinbereznak » Tue Oct 19, 2010 10:16 am

Fuzzy could you make your ThatJustHappened.xml and ThatJustHappened.lua files available somewhere? If not I'll just make the changes given in this post. Of all the addons I've used, I miss this one the most :cry:
Penji on Mal'Ganis
tobinbereznak
 
Posts: 3
Joined: Thu Nov 19, 2009 11:11 am

Re: ThatJustHappened: Combat Event Announcement Mod

Postby fuzzygeek » Tue Oct 19, 2010 10:34 am

Echaa wrote:Does what line they're on have any bearing at all on what their function is?


No. Line numbers are just a guide to help find the code. You can ignore the line numbers entirely as long as you update the references.

If the mod author doesn't update it in the next couple weeks I'll post a fork or something; I don't know what the convention is for continuing an abandoned project on wowinterface etc.
Image
User avatar
fuzzygeek
Maintankadonor
 
Posts: 3447
Joined: Wed Aug 01, 2007 1:58 pm

PreviousNext

Return to Add-ons, UI, and Macros

Who is online

Users browsing this forum: No registered users and 1 guest

Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 5 minutes)
Most users ever online was 380 on Tue Oct 14, 2008 6:28 pm

Users browsing this forum: No registered users and 1 guest