A Call to Arms - Cataclysm Mechanics testing

[theckhd]

I'm not sure what you mean. The current code for player.wdamage is

player.wdamage = gear.avgdmg+player.ap*gear.swing/14

Are you saying that for instant attacks, the game uses a normalized value for gear.swing instead of the weapon value (for example 2.0 instead of 1.6)? A quick numbers check shows that if it were normalized to 2.5, that would put CS's damage at 218, right where Kierly's data set puts it. But it wouldn't explain why HotR doesn't behave the same way.

[Flex]

1H non-dagger weapon normalization is 2.4 second swing speed.

[tlitp]

Also, has anyone observed whether Grand Crusader procs off of a miss/dodge/parry? The wording of the talent certainly seems to indicate that it does not, but since it should have a significant effect on the simulations, I want to be sure.

Also, we're interested in Sacred Duty. Is a Judgement that doesn't connect able to proc it ?

Code: Select all

player.wdamage = gear.avgdmg+player.ap*gear.swing/14

Teehee, this kind of oversights make a man's day.
Quick fix : keep .wdamage for non-normalized attacks (AAs, Reck), squeeze in a .ndamage that is later used in [AM].

[Sabindeus]

I'm not sure what you mean. The current code for player.wdamage is

player.wdamage = gear.avgdmg+player.ap*gear.swing/14

Are you saying that for instant attacks, the game uses a normalized value for gear.swing instead of the weapon value (for example 2.0 instead of 1.6)? A quick numbers check shows that if it were normalized to 2.5, that would put CS's damage at 218, right where Kierly's data set puts it. But it wouldn't explain why HotR doesn't behave the same way.

Um. yeah? I mean I dunno about HotR, but instant attacks have had their AP contribution normalized since like 1.4? or so? When Mortal Strike was destroying everyone in the face.


I forget let me look it up

Here you go: http://www.wowwiki.com/Normalization

Turns out it was patch 1.8. Vanilla patches all run together in my head. Quoting a bit to correct my earlier numbers:

The normalized weapon damage for instant attacks is:
normalized_damage = base_weapon_damage + (X * Attack Power / 14)
where X is:
1.7 for daggers
2.4 for other one-handed weapons
3.3 for two-handed weapons
2.8 for ranged weapons

[theckhd]

I think I remember when that occurred, but I had totally forgotten about it. We never had a weapon-damage instant strike as Prot in Wrath, so it was never an issue from a coding perspective.

Also, I coded that line in... August? Good to know tlitp is thoroughly checking my work.

I'll make the required changes and see if that fixes things, expect a commit in an hour or so.

[tlitp]

Also, I coded that line in... August? Good to know tlitp is thoroughly checking my work.

I love you too.

[theckhd]

Well what do you know, that seems to fix CS perfectly.

Kierly's data sets (omitting irrelevant entries):

Code: Select all

#1     Model   Obs   Diff  %Err
CS       213   215      2     1
JoT     1242  1140   -102    -8
AS      3787  3764    -23    -1
Exor    1500  1527     27     2
SoT       23    23     -1    -2
SoR       90    95      5     6
SoJ       41    41      0     0
Cens    1118  1080    -38    -3
Cons    2100  2100      0     0
HotR      33    26     -7   -21
HaNova  1441  1452     11     1
Melee     89    90      1     2

#2
CS       213   218      5     2
JoT     1242  1242      0     0
AS      3787  3854     67     2
SoT       23    23     -0    -1
SoR       90    95      5     6
SoJ       41    41      0     0
Cens    1118  1115     -3    -0
Melee     89    92      3     3

Ras' set:

Code: Select all

       Model   Obs   Diff  %Err
ShoR    1225  1231      6     0
CS      1464  1476     12     1
JoT      520   520      0     0
AS      3615  3605    -10    -0
HW      2600  2601      1     0
HoW     1522     0  -1522  -100
Exor    1354  1354      0     0
SoT      203   204      1     0
SoR       54    57      3     6
SoJ       25    24     -1    -4
Cens     835   838      3     0
Cons    1645  1645      0     0
HotR     229   231      2     1
HaNova   847   842     -5    -1
Melee    772   776      4     1

So that solves our CS conundrum. It seems to work fine for HotR with a slow weapon (unsurprisingly) but breaks for fast weapons, indicating that HotR is either coded differently or we're still missing something.

Easiest thing to check would Test #2 with HotR, to see exactly how it scales with weapon speed.

[theckhd]

Test #3: HotR weapon normalization

Step 1: Purchase a Dalaran Sword (Valaden Silverblade in Dalaran) and a Falchion (Lissaf in Shattrath, Lower City).

Step 2: Spec 0/38/0, get naked except for the weapon (no shield for simplicity). Use Seal of Righteousness. Log about 100-200 HotR attacks with each weapon. Please try and keep the logs separate (i.e. stop logging and upload after each weapon). Post a link to each log along with the weapon used and paper doll AP, SP.

[Arianne]

Hey Theck,

I'm on the PTR right now and have some time to test. What do we need tested on the PTR?

[tlitp]

If you have a lot of time at disposition, replicate this for ptr@80 (attack a lvl80 dummy). If you don't, take a look at GC/SD.

EDIT : Also, HotR. (medium duration)

[theckhd]

This request is still on the books as well. I'd like to nail down level 80 base damages primarily, so the focus would be HotR splash, HoW, Cons, AS, Exorcism, and HW.

Though the things tlitp listed are slightly higher priority, I think.

[Arianne]

I'm at the Theramore dummies. There's no way I can not hit around 5 of them with each HotR. Should I move somewhere else?

[tlitp]

I'm at the Theramore dummies. There's no way I can not hit around 5 of them with each HotR.

We're interested only in the physical component. The fewer targets, the better - the CL entries will be more sparse.

[Arianne]

Ok. I'll redo them at Exodar (only hitting 2 dummies), but here are the logs in case they're useful

http://www.worldoflogs.com/reports/3sl3bic1t578gak3/ CS - Dalasword - Theramore
http://www.worldoflogs.com/reports/oc9r2g0qin3zzmam/ HotR - Dalasword - Theramore
http://www.worldoflogs.com/reports/4d7vibwpc5v39mqo/ HotR - Falchion - Theramore
http://www.worldoflogs.com/reports/oxeh1jvrsp7hswfn/ HotR - Dalasword - Exodar
http://www.worldoflogs.com/reports/oo9meho29lyr468r/ HotR - Falchion - Exodar

The Theramore dummies are level 1 as well. The only way I can get 2 dummies at Exodar is by attacking the level 60 one. If I attack the level 80 one I hit the level 60 one and the level 70 one as well.

[Kierly]

Also, has anyone observed whether Grand Crusader procs off of a miss/dodge/parry? The wording of the talent certainly seems to indicate that it does not, but since it should have a significant effect on the simulations, I want to be sure.

I Looked through my parses from when I did the tests yesterday of the 400 crusader strikes and not one of the misses caused the grand crusader buff to appear. Now I know that does not prove anything but the following query's can help to see if one ever does cause it.

Code: Select all

[{"spellNames": ["Crusader Strike"], "eventTypes": [2]}, {"spellNames": ["Grand Crusader"], "eventTypes": [4]}, {"spellNames": ["Hammer of the Righteous"], "eventTypes": [2]}]